fixed a small inconsistent xml attribute #694
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
btw, I've signed the CLA |
Member
@ericaro Yes, but you don't have your full name in your git config. Could you update your git config to include your full name? |
the progressCallbacks argument is not consistent with other like this in the documentation: the second argument is optional (like any other deferred.always etc.)
Contributor
Author
|
I think I've got the green flag from jquerybot ! |
Member
|
Looks good! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the deferred.progress.xml the second "argument" is not marked as optional
it is marked optional in all other entries ( deferred.always.xml:11 etc.)